Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/tx): add aminoNameAsTypeURL option in aminojson encoder (backport #21712) #21798

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 18, 2024

Description

Closes: #21261

Afterwards, I'll tag a new x/tx and bump it in autocli for 0.52 and 0.50 to make use of that new option.

before

$ simd q feegrant grant alice bob
allowance:
  allowance:
    type: cosmos-sdk/BasicAllowance
    value:
      spend_limit:
      - amount: "100"
        denom: stake
  grantee: cosmos18ac8zvrnaezk9unff26sre7c22r07frzw4yavs
  granter: cosmos1x4gsc5t9n646y5csw2wqz3rjsym0dz2fczkztf

after

$ simd q feegrant grant alice bob
  allowance:
    allowance:
      type: /cosmos.feegrant.v1beta1.BasicAllowance
      value:
        spend_limit:
        - amount: "100"
          denom: stake
    grantee: cosmos18ac8zvrnaezk9unff26sre7c22r07frzw4yavs
    granter: cosmos1x4gsc5t9n646y5csw2wqz3rjsym0dz2fczkztf

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Enhanced query handling with the type field now represented as a proto message URL.
    • Added support for off-chain signing and verification of files.
    • Introduced governance proposals for improved SDK functionality.
  • Improvements

    • Improved Amino JSON encoder with the new AminoNameAsTypeURL option for better type URL handling.
    • Enhanced thread safety in context management for signers.
  • Bug Fixes

    • Updated marshaling processes to accommodate new parameters for better encoding flexibility.

This is an automatic backport of pull request #21712 done by [Mergify](https://mergify.com).

)

Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
(cherry picked from commit 0c8ad9d)

# Conflicts:
#	client/v2/CHANGELOG.md
#	x/tx/CHANGELOG.md
@mergify mergify bot requested a review from a team as a code owner September 18, 2024 09:55
@mergify mergify bot added the conflicts label Sep 18, 2024
Copy link
Contributor Author

mergify bot commented Sep 18, 2024

Cherry-pick of 0c8ad9d has failed:

On branch mergify/bp/release/v0.50.x/pr-21712
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit 0c8ad9d2c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   client/v2/autocli/query.go
	modified:   x/tx/signing/aminojson/json_marshal.go
	modified:   x/tx/signing/aminojson/json_marshal_test.go
	modified:   x/tx/signing/aminojson/options.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   client/v2/CHANGELOG.md
	both modified:   x/tx/CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

coderabbitai bot commented Sep 18, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@julienrbrt julienrbrt marked this pull request as draft September 18, 2024 09:56
@julienrbrt julienrbrt self-assigned this Sep 18, 2024
@github-actions github-actions bot removed the C:CLI label Sep 18, 2024
@julienrbrt
Copy link
Member

I'll update client/v2 once this is merged and x/tx 0.13.5 is tagged

@julienrbrt julienrbrt marked this pull request as ready for review September 18, 2024 10:32
@julienrbrt julienrbrt merged commit 7ee3115 into release/v0.50.x Sep 18, 2024
44 of 46 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.50.x/pr-21712 branch September 18, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant