Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greg/docs deployment #2185

Merged
merged 3 commits into from
Aug 29, 2018
Merged

Greg/docs deployment #2185

merged 3 commits into from
Aug 29, 2018

Conversation

greg-szabo
Copy link
Member

  • Targeted PR against correct branch (see CONTRIBUTING.md) - targeted against master as it is a hotfix for the production website.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work. - tendermint/devops/issues/59

  • Wrote tests - ran on staging with success

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue # - not a user-facing change

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

zramsay and others added 3 commits August 29, 2018 15:37
This change will put the documentation to the right folder for website deployment.
@greg-szabo greg-szabo added T:Bug T:Docs Changes and features related to documentation. prelaunch labels Aug 29, 2018
@codecov
Copy link

codecov bot commented Aug 29, 2018

Codecov Report

Merging #2185 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2185   +/-   ##
=======================================
  Coverage   63.76%   63.76%           
=======================================
  Files         113      113           
  Lines        6671     6671           
=======================================
  Hits         4254     4254           
  Misses       2131     2131           
  Partials      286      286

@ebuchman ebuchman merged commit f15139f into master Aug 29, 2018
@ebuchman ebuchman deleted the greg/docs-deployment branch August 29, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Bug T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants