fix(baseapp): startTime of telemetry metric should be calculated before defer

[beepdeepor]

Description

Similar to the changes in #21963

Summary by CodeRabbit

• Bug Fixes
  • Improved the timing of telemetry measurement initiation for enhanced performance tracking.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes involve a modification to the Query method of the BaseApp struct in the baseapp/abci.go file. The update alters the telemetry measurement process by introducing a two-step approach for recording the start time. Instead of directly calling telemetry.MeasureSince with the current time, a variable start is first assigned the value of telemetry.Now(), which is then used in a deferred call to telemetry.MeasureSince. This change affects the timing of when the start time is recorded without altering the overall functionality.

Changes

Files	Change Summary
baseapp/abci.go	Modified the Query method to change the telemetry measurement initiation to a two-step process.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant BaseApp
    participant Telemetry

    Client->>BaseApp: Query Request
    BaseApp->>Telemetry: Now() -> start
    BaseApp->>Telemetry: MeasureSince(start, req.Path) (deferred)
    BaseApp-->>Client: Query Response

Loading

---

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 39682b0 and 0735702.

📒 Files selected for processing (1)

• baseapp/abci.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• baseapp/abci.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[julienrbrt]

Yep, thank you!