Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: double curlies breaks vuepress - single curlies does not #2203

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

greg-szabo
Copy link
Member

  • Targeted PR against correct branch (see CONTRIBUTING.md) - Targeted master, cherry-picked change from develop.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work. - tendermint/devops/issues/59 - fix docs auto-deployment

  • Wrote tests - tested on staging

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue # - not a user-facing change

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@greg-szabo greg-szabo added T:Bug T:Docs Changes and features related to documentation. ready-for-review labels Aug 31, 2018
@greg-szabo greg-szabo requested a review from cwgoes August 31, 2018 16:14
@codecov
Copy link

codecov bot commented Aug 31, 2018

Codecov Report

Merging #2203 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2203   +/-   ##
=======================================
  Coverage   63.76%   63.76%           
=======================================
  Files         113      113           
  Lines        6671     6671           
=======================================
  Hits         4254     4254           
  Misses       2131     2131           
  Partials      286      286

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK but I can't merge to master

@ebuchman ebuchman merged commit 416181b into master Aug 31, 2018
@ebuchman ebuchman deleted the greg/website-hotfix branch August 31, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Bug T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants