feat(baseapp): Abort OE in PrepareProposal (Upstream dydx) #22287
Conversation
julienrbrt
added
the
backport/v0.52.x
julienrbrt
requested review from
facundomedica,
aaronc,
testinginprod,
kocubinski and
a team
as code owners
📝 WalkthroughWalkthroughThe changes in the pull request focus on the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant BaseApp
participant OptimisticExec
Client->>BaseApp: PrepareProposal()
BaseApp->>OptimisticExec: Abort() (if optimistic execution running)
BaseApp->>Client: Proposal prepared
Client->>BaseApp: ProcessProposal()
BaseApp->>OptimisticExec: Abort() (if proposal height exceeds)
BaseApp->>Client: Proposal processed
BaseApp->>BaseApp: FinalizeBlock()
BaseApp->>OptimisticExec: Wait for execution result
alt Execution aborted
BaseApp->>BaseApp: Reset state
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
@julienrbrt your pull request is missing a changelog! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return nil, errors.New("PrepareProposal handler not set") | ||
| } | ||
|
|
||
| // Abort any running OE so it cannot overlap with `PrepareProposal`. This could happen if optimistic | ||
| // `internalFinalizeBlock` from previous round takes a long time, but consensus has moved on to next round. | ||
| // Overlap is undesirable, since `internalFinalizeBlock` and `PrepareProoposal` could share access to | ||
| // in-memory structs depending on application implementation. |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).PrepareProposal (baseapp/abci.go:407)
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
baseapp/abci.go (1)
414-414: Correct typo in comment: 'PrepareProoposal' should be 'PrepareProposal'There is a typo in the comment at line 414. The function name
PrepareProoposalshould be corrected toPrepareProposal.Apply this diff to fix the typo:
- // Overlap is undesirable, since `internalFinalizeBlock` and `PrepareProoposal` could share access to + // Overlap is undesirable, since `internalFinalizeBlock` and `PrepareProposal` could share access to
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (1)
- baseapp/abci.go (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
baseapp/abci.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Co-authored-by: Teddy Ding <teddy@dydx.exchange> (cherry picked from commit 11698aa)
Description
upstream dydxprotocol@38e40ba
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes