Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improvements on rest v2 server #22292

Merged
merged 4 commits into from
Oct 17, 2024
Merged

refactor: improvements on rest v2 server #22292

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3335078
update api enpoint
hieuvubk Oct 17, 2024
c0c0f75
feedback
hieuvubk Oct 17, 2024
732ac3e
revert
hieuvubk Oct 17, 2024
caffcc8
add rest to confix
hieuvubk Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/init-simapp-v2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if [ -d "$SIMD_HOME" ]; then rm -rv $SIMD_HOME; fi
$SIMD_BIN config set client chain-id simapp-v2-chain
$SIMD_BIN config set client keyring-backend test
$SIMD_BIN config set client keyring-default-keyname alice
$SIMD_BIN config set app api.enable true
$SIMD_BIN config set app rest-v2.enable true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we as well rename the server to simply rest? I don't think we should have v2 in there.

$SIMD_BIN keys add alice --indiscreet
$SIMD_BIN keys add bob --indiscreet
$SIMD_BIN init simapp-v2-node --chain-id simapp-v2-chain
Expand Down
Loading