chore(simdv2): allow overriding the --home flag (backport #22348) #22350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 864ae34)
sontrinh16
approved these changes
Oct 23, 2024
julienrbrt
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two calls to viper.Set(serverv2.FlagHome, simapp.DefaultNodeHome); these calls invalidated any provided --home command line arguments. When testing multiple simapp instances in the same process, it is necessary to provide separate home directories.
Changing the calls from .Set to .SetDefault retains the previous behavior of using DefaultNodeHome when no --home flag is provided, but it still respects --home when the flag is indeed provided.
Summary by CodeRabbit
Bug Fixes
Refactor
This is an automatic backport of pull request #22348 done by [Mergify](https://mergify.com).