Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Minor changes on slashing logs and gov Querier #2259

Merged
merged 7 commits into from
Sep 12, 2018

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Sep 7, 2018

Part 2 of the split process from #2139.
This one adds constants to queriers and has minor changes to logs for better readability.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze self-assigned this Sep 7, 2018
@fedekunze fedekunze changed the title R4R: Minor changes logs and gov Querier R4R: Minor changes on slashing logs and gov Querier Sep 7, 2018
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fedekunze -- I left some feedback on how I think the logs could change slightly. Otherwise, LGTM 👍

x/gov/handler.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@e5e7c4f). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff             @@
##             develop    #2259   +/-   ##
==========================================
  Coverage           ?   63.88%           
==========================================
  Files              ?      140           
  Lines              ?     8694           
  Branches           ?        0           
==========================================
  Hits               ?     5554           
  Misses             ?     2758           
  Partials           ?      382

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor thing @fedekunze -- thanks!

x/gov/handler.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK -- attempt a merge of develop @fedekunze to resolve any CI issues.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 5834a50 into develop Sep 12, 2018
@cwgoes cwgoes deleted the fedekunze/refactor-gov-querier branch September 12, 2018 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants