Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename coinKeeper -> bankKeeper #2273

Merged
merged 2 commits into from
Sep 8, 2018
Merged

Rename coinKeeper -> bankKeeper #2273

merged 2 commits into from
Sep 8, 2018

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Sep 8, 2018

Closes #2267

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue # - no changelog entry made since this was never exported, therefore breaks no API.

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 8, 2018

Codecov Report

Merging #2273 into develop will not change coverage.
The diff coverage is 81.81%.

@@           Coverage Diff            @@
##           develop    #2273   +/-   ##
========================================
  Coverage    63.73%   63.73%           
========================================
  Files          140      140           
  Lines         8642     8642           
========================================
  Hits          5508     5508           
  Misses        2755     2755           
  Partials       379      379

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems quite straightforward. ACK from me.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks @ValarDragon

Much less confusing now

@cwgoes cwgoes merged commit ffb4c5e into develop Sep 8, 2018
@cwgoes cwgoes deleted the dev/rename_bankKeeper branch September 8, 2018 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants