genesis: Ensure there are no duplicate accounts in genesis file #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
This also contains a light refactor of genesis state parsing, so that the tests file didn't duplicate a lot of this code.
ValarDragon
force-pushed
the
dev/validate_genesis_file
branch
from
550f400
to
373eff6
Compare
ValarDragon
commented
Sep 8, 2018
cmd/gaia/app/genesis.go
Outdated
| // TODO: Ensure all state machine parameters are in genesis (#1704) | ||
| func GaiaValidateGenesisState(cdc *wire.Codec, genesisState GenesisState) (err error) { | ||
| err = validateGenesisStateAccounts(genesisState.Accounts) | ||
| if err != nil { |
There was a problem hiding this comment.
I know this is kind of weird, I left this like this, as there will be more tests here as more todo's are completed.
Codecov Report
@@ Coverage Diff @@
## develop #2275 +/- ##
===========================================
+ Coverage 63.74% 63.83% +0.08%
===========================================
Files 140 140
Lines 8645 8666 +21
===========================================
+ Hits 5511 5532 +21
+ Misses 2755 2754 -1
- Partials 379 380 +1 |
|
@ValarDragon Looks like there's a merge conflict now. |
|
Conflict fixed! |
cwgoes
approved these changes
Sep 8, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also contains a light refactor of genesis state parsing, so that
the tests file didn't duplicate a lot of this code.
Handles one of the items in #2229. This is also the only test that verifies any of the genesis file code AFAIK (albeit not much)
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/) - n/aAdded entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: