cachekvstore: Remove conditional branching in calls within sort

[ValarDragon]

These removes conditional branching from calls within dirtyItems sort. This changes the benchmarks in #2286 that stated dirtyItems took 31% of time over 100 blocks to it now taking 13%. I believe this is due to not having to keep ascending in a register. However in the 200 blocks case, it basically only cuts out 1 second out of the 56 seconds spent there, so not as big of a performance increase.

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #2287 into develop will increase coverage by <.01%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop    #2287      +/-   ##
===========================================
+ Coverage    63.87%   63.88%   +<.01%     
===========================================
  Files          140      140              
  Lines         8682     8685       +3     
===========================================
+ Hits          5546     5548       +2     
- Misses        2756     2757       +1     
  Partials       380      380

[alexanderbez]

utACK -- it may help to post benchmark results in the PRs as well (although I do trust you 😃 )

[ValarDragon]

Huh wrote a benchmark, and this actually made no difference. Not sure why it appeared that it did in simulation, perhaps other background processes on my system. I'll close this for now then!