R4R: Change --gas=0 semantic and introduce --gas=simulate

[alessio]

Make --gas flag accept a conventional "simulate" string value in addition
to integers. Passing --gas=simulate would trigger the tx simulation and
set the gas according to the gas estimate returned by the simulation.
Any other integer value passed to --gas would be interpreted as-is and
and set as gas wanted value.

Closes: #2300

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added entries in PENDING.md with issue #
• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #2306 into develop will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #2306      +/-   ##
===========================================
+ Coverage    63.94%   63.95%   +<.01%     
===========================================
  Files          140      140              
  Lines         8689     8688       -1     
===========================================
  Hits          5556     5556              
+ Misses        2757     2756       -1     
  Partials       376      376

[fedekunze]

Looks good. Left some comments with some test cases that are missing.

Also I think we should change the gas type to uint. Auditors have rise that concern a couple times already.

[alexanderbez]

utACK -- left some general feedback. Also, broken lint CI needs to be addressed...not sure what is going on there.

[alessio]

Appreciated, thanks!

…

On Tue, Sep 11, 2018 at 6:59 PM, Dev Ojha ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In client/flags.go <#2306 (comment)>: > } return cmds } + +// Gas flag parsing functions + +// GasSetting encapsulates the possible values passed through the --gas flag. +type GasSetting struct { + Simulate bool + Gas int64 #2173 <#2173> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2306 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN_7JTPPZLubTQXq4__HPcO1q5jLn7Fks5uZ_ofgaJpZM4WjHzo> .

-- Alessio Treglia | alessio@tendermint.com 0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A

[rigelrozanski]

untestedACK and on latest develop 👍

resolved