Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: linting fixes #23136

Merged
merged 5 commits into from
Dec 31, 2024
Merged

chore: linting fixes #23136

merged 5 commits into from
Dec 31, 2024

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Dec 31, 2024

Description

this pr aims to fix some of the liniting issues we are facing today


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated Go version to 1.22 across multiple modules
    • Updated GitHub Actions workflow configurations
    • Added an indirect dependency on golang.org/x/exp
  • Tests

    • Minor cleanup in test files, removing redundant variable declarations
    • Simplified variable declarations in integration test files
  • Dependencies

    • Retracted specific versions of the math module
    • Adjusted gRPC dependency replacement

Copy link
Contributor

coderabbitai bot commented Dec 31, 2024

📝 Walkthrough

Walkthrough

This pull request focuses on updating Go versions across multiple modules and GitHub Actions workflows. The changes primarily involve upgrading Go versions from 1.20/1.21 to 1.22 in various go.mod files for modules like depinject, errors, log, and math. The GitHub Actions workflow file .github/workflows/test.yml is also updated to use the new Go versions. Additionally, some minor code cleanup is performed in test files, such as removing redundant variable declarations.

Changes

File Change Summary
.github/workflows/test.yml Updated Go versions for multiple jobs: 1.21 → 1.22, 1.20 → 1.22, 1.21 → 1.23, 1.23 → 1.23.2
depinject/go.mod Go version updated from 1.21 to 1.22; modified grpc dependency replacement
errors/go.mod Go version updated from 1.20 to 1.22
log/bench_test.go Removed variable shadowing in BenchmarkLoggers function
log/go.mod Go version updated from 1.21 to 1.22
math/go.mod Go version updated from 1.20 to 1.22; added indirect dependency on golang.org/x/exp; retracted specific module versions
math/legacy_dec_test.go Removed redundant variable declaration
tests/integration/v2/example/example_test.go Simplified mintKeeper variable declaration

Possibly related PRs

Suggested reviewers

  • sontrinh16
  • julienrbrt
  • akhilkumarpilli
  • lucaslopezf
  • kocubinski

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4fb2347 and 18dee22.

⛔ Files ignored due to path filters (1)
  • math/go.sum is excluded by !**/*.sum
📒 Files selected for processing (8)
  • .github/workflows/test.yml (3 hunks)
  • depinject/go.mod (1 hunks)
  • errors/go.mod (1 hunks)
  • log/bench_test.go (0 hunks)
  • log/go.mod (1 hunks)
  • math/go.mod (1 hunks)
  • math/legacy_dec_test.go (0 hunks)
  • tests/integration/v2/example/example_test.go (1 hunks)
💤 Files with no reviewable changes (2)
  • log/bench_test.go
  • math/legacy_dec_test.go
✅ Files skipped from review due to trivial changes (4)
  • errors/go.mod
  • log/go.mod
  • depinject/go.mod
  • tests/integration/v2/example/example_test.go
🔇 Additional comments (3)
math/go.mod (2)

3-3: LGTM: Go version update and dependency changes.

The update to Go 1.22 and the addition of the golang.org/x/exp dependency are appropriate changes.

Also applies to: 6-6


Line range hint 31-39: Well-documented version retractions.

The retractions are properly documented with clear explanations for each retracted version:

  • Issues with math.Int{}.Size() implementation
  • Bit length differences between Int and Dec
.github/workflows/test.yml (1)

286-286: LGTM: Consistent Go version updates across test jobs.

The Go version updates to 1.22 in the test jobs for depinject, errors, and math modules are consistent with their respective go.mod files.

Also applies to: 315-315, 346-346


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the C:log label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants