ci: ci cleanup #23192
ci: ci cleanup #23192
Conversation
|
Warning Rate limit exceeded@tac0turtle has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 52 minutes and 52 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request involves a comprehensive removal of RocksDB-related scripts, workflow configurations, and build settings across multiple files in the project. The changes systematically eliminate dependencies, installation scripts, caching mechanisms, and build configurations associated with RocksDB. The modifications suggest a strategic decision to remove RocksDB as a supported database backend, affecting GitHub Actions workflows, build scripts, and test configurations. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
scripts/build/build.mk
Outdated
| @@ -55,11 +53,6 @@ ifeq (v2,$(findstring v2,$(COSMOS_BUILD_OPTIONS))) | |||
| endif | |||
|
|
|||
| # DB backend selection | |||
| # handle rocksdb | |||
There was a problem hiding this comment.
We need to keep this one if the user wants to use rocksdb for cometbft.
| @@ -77,4 +58,3 @@ jobs: | |||
| env: | |||
There was a problem hiding this comment.
We can simplify the jobs, as we had a special case if it was running in store and not in store,
scripts/build/build.mk
Outdated
| @@ -14,6 +14,8 @@ DOCKER := $(shell which docker) | |||
| PROJECT_NAME = $(shell git remote get-url origin | xargs basename -s .git) | |||
| COSMOS_BUILD_OPTIONS += ' v2' | |||
|
|
|||
| rocksdb_version=v9.7.3 | |||
There was a problem hiding this comment.
This can be deleted however :D
|
@Mergifyio backport release/v0.52.x |
✅ Backports have been created
|
|
Partially backporting this, as this touched store/v2 that we use in release/v0.52.x as well. |
(cherry picked from commit 787a713) # Conflicts: # .github/workflows/build.yml
Description
remove rocksdb from ci as its not supported out of the box anymore.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Removed Dependencies
Build Process Changes
The changes indicate a comprehensive removal of RocksDB-related infrastructure and build dependencies across the project's continuous integration setup.