ADR for global message counter #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
force-pushed
the
dev/global_msg_counter
branch
from
937cc15 to
090a702
Compare
| ## Decision | ||
|
|
||
| Create a global message counter field of type uint64. | ||
| The choice of uint64 is because it is only getting incremented by |
There was a problem hiding this comment.
I'd prefer us to be consistent and use an int64 here. Although isolated it may seem fine - I think this term will have a tendency to be used in arithmetic, which may cause bad decisions down the road of somebody using uint64 for arithmetic instead of int64.
| @@ -0,0 +1,54 @@ | |||
| # ADR 001: Global Message Counter | |||
There was a problem hiding this comment.
nice! maybe we should even have this file in an ADR subdirectory within architecture? or it's probably fine for now - but at some point in the future we should fill the docs/architecture with all sorts or architecture related goodies not just ADRs
Codecov Report
@@ Coverage Diff @@
## develop #2334 +/- ##
==========================================
Coverage ? 65.04%
==========================================
Files ? 135
Lines ? 8399
Branches ? 0
==========================================
Hits ? 5463
Misses ? 2574
Partials ? 362 |
ValarDragon
force-pushed
the
dev/global_msg_counter
branch
from
e15187e to
60a7422
Compare
related stuff in the future
alexanderbez
approved these changes
Sep 14, 2018
cwgoes
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this as an ADR, as I think it may be useful to begin to do that for more SDK API level things. (Though in hindsight, this was small enough that its really easy to have summarized it in an issue)
/cc @rigelrozanski @cwgoes @alexanderbez
This is based off our conversation in #2312
For Admin Use: