-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: removed governance slashing #2395
Conversation
4f379c8
to
a0bbcde
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2395 +/- ##
===========================================
- Coverage 63.54% 63.12% -0.43%
===========================================
Files 120 120
Lines 7236 7224 -12
===========================================
- Hits 4598 4560 -38
- Misses 2326 2350 +24
- Partials 312 314 +2 |
Hrmm. An interesting consequence of this is that the the simulator will no longer catch a significant portion of the slashing bugs its been finding, until we fix #2320. This is because they were all being caught on governance slashing, and only execute after a slashing occurred. We'll have to do a bunch more work to now test our staking code, but thats nbd. I'll make a follow-up issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK -- thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK but waiting to merge for the moment (want to wait for simulation updates re @ValarDragon's comment)
Ref: #2396 |
closes #2256
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: