Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Sign/Validate sigs on GenesisTx #2410

Closed
wants to merge 7 commits into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Sep 26, 2018

Ref #1890

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

Merging #2410 into develop will decrease coverage by 0.18%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #2410      +/-   ##
===========================================
- Coverage    61.53%   61.35%   -0.19%     
===========================================
  Files          122      123       +1     
  Lines         7472     7494      +22     
===========================================
  Hits          4598     4598              
- Misses        2554     2576      +22     
  Partials       320      320

Alessio Treglia added 5 commits September 27, 2018 12:11
Replaced by the StdTx generated by the
gaiacli tx create-validator --generate-only command's output.
@alessio alessio closed this Sep 29, 2018
@alessio alessio deleted the alessio/1890-signed-gen-txs branch September 29, 2018 15:45
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
…2410)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3.1.1...v3.1.2)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant