Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Add Query Proposal's deposits endpoint #2488

Merged
merged 7 commits into from
Oct 15, 2018
Merged

R4R: Add Query Proposal's deposits endpoint #2488

merged 7 commits into from
Oct 15, 2018

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Oct 13, 2018 •
edited
Loading

Closes #2478

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 13, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@6c9e71b). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             develop    #2488   +/-   ##
==========================================
  Coverage           ?   61.93%           
==========================================
  Files              ?      150           
  Lines              ?     9476           
  Branches           ?        0           
==========================================
  Hits               ?     5869           
  Misses             ?     3199           
  Partials           ?      408

cwgoes
cwgoes previously requested changes Oct 13, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes req'd.

x/gov/client/rest/rest.go Show resolved Hide resolved
client/lcd/lcd_test.go Show resolved Hide resolved
@fedekunze fedekunze dismissed cwgoes’s stale review October 15, 2018 08:46

addressed comments

@fedekunze
Copy link
Collaborator Author

@cwgoes passing all tests now

cwgoes
cwgoes approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit db7b1c8 into develop Oct 15, 2018
@cwgoes cwgoes deleted the fedekunze/2478-gov-deposits-rest branch October 15, 2018 16:53
@jackzampolin
Copy link
Member

🎉 🎉 🎉 🎉 🎉 🎉

@snyk-bot snyk-bot mentioned this pull request Jan 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees
No one assigned
Labels
C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedekunze @jackzampolin @cwgoes