R4R: Refactor validator deletion #2514
Conversation
sunnya97
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
sunnya97
force-pushed
the
sunny/refactor-validator-deletion-2
branch
from
8faa75f
to
193e53f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2514 +/- ##
==========================================
+ Coverage 57.87% 57.9% +0.02%
==========================================
Files 140 140
Lines 8119 8119
==========================================
+ Hits 4699 4701 +2
+ Misses 3123 3121 -2
Partials 297 297 |
sunnya97
force-pushed
the
sunny/refactor-validator-deletion-2
branch
from
193e53f
to
e8c7a2f
Compare
sunnya97
force-pushed
the
sunny/refactor-validator-deletion-2
branch
from
381be29
to
88f3b03
Compare
sunnya97
changed the title
|
Can you make a follow-up issue to ensure the simulator will run this scenario? |
docs/spec/staking/end_block.md
Outdated
| if validator.DelegatorShares != 0 { | ||
| RemoveValidator(unbondingValidator) | ||
| } else { | ||
| validator.Status = sdk.Bonded |
There was a problem hiding this comment.
Huh why would we set the status to bonded?
There was a problem hiding this comment.
Oh good catch, should be unbonded
x/stake/keeper/delegation.go
Outdated
| if validator.DelegatorShares.IsZero() && validator.Status != sdk.Bonded { | ||
| // if bonded, we must remove in EndBlocker instead | ||
| if validator.DelegatorShares.IsZero() && validator.Status == sdk.Unbonded { | ||
| // if not unbonded, we must remove in EndBlocker instead |
There was a problem hiding this comment.
"we must remove in EndBlocker or at the end of the unbonding queue instead"
There was a problem hiding this comment.
Those are the same thing. The unbonding queue is processed during the EndBlocker
x/stake/keeper/slash.go
Outdated
| if validator.Tokens.IsZero() && validator.Status != sdk.Bonded { | ||
| // if bonded, we must remove in ApplyAndReturnValidatorSetUpdates instead | ||
| if validator.Tokens.IsZero() && validator.Status == sdk.Unbonded { | ||
| // if not unbonded, we must remove in EndBlocker instead |
There was a problem hiding this comment.
Should we check DelegatorShares instead of Tokens here? Also I think the comment needs to be updated - "we must remove in EndBlocker or at the end of the unbonding queue instead".
There was a problem hiding this comment.
Yeah sure. They should have the same effect, but can I can change it to DelegatorShares.IsZero() to remain consistent.
…os/cosmos-sdk into sunny/refactor-validator-deletion-2
closes #1673
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: