sim fixes #2564
Merged
sim fixes #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelrozanski
force-pushed
the
jae/check-supply-in-simulation2
branch
from
5a559f7 to
fa3730a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rige [12:05 AM]
so I figured out the bug - it was in the simulation logic - basically all the validators have been unbonded and the simulation assumed it was okay to keep running with a nil proposer! - added a check which stop and exits the simulation if all the validators have been unbonded.
rige [12:05 AM]
however I’m really really confused as to why validators are unbonding given that the unbond delegation transaction has been disabled…
rige [12:21 AM]
OH it’s because they are getting jailed once in a while
phew - I thought this was something super messy
rige [12:27 AM]
still on your branch - just turned up the %weight of unjail msgs by 10x…… already at block 100 (promising)….. ah still stops at 113 due to not enough validators again, going to enable other messages just to se