Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: distribution refactor #2578

Closed
wants to merge 7 commits into from
Closed

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Oct 24, 2018

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #2578 into develop will decrease coverage by 0.18%.
The diff coverage is 48.71%.

@@            Coverage Diff             @@
##           develop   #2578      +/-   ##
==========================================
- Coverage    60.08%   59.9%   -0.19%     
==========================================
  Files          150     151       +1     
  Lines         8704    8754      +50     
==========================================
+ Hits          5230    5244      +14     
- Misses        3116    3152      +36     
  Partials       358     358

@rigelrozanski rigelrozanski changed the title WIP: distribution rewards query WIP: distribution refactor Oct 25, 2018
@jaekwon
Copy link
Contributor

jaekwon commented Oct 25, 2018

hold this PR please.

@rigelrozanski
Copy link
Contributor Author

Sure - @jaekwon feel free to make changes directly here - it's all yours

@rigelrozanski
Copy link
Contributor Author

rigelrozanski commented Oct 26, 2018

replaced by #2597 and #2599

@rigelrozanski rigelrozanski deleted the rigel/query-rewards branch October 26, 2018 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants