Release 0.25.0 (second try) #2603

cwgoes · 2018-10-26T11:45:40Z

Release 0.25.0

PR to merge back to develop: #2604

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* Correctly set proposer in randomized simulation * Return nil if no validators are present

…tion

…smos-sdk into rigel/fee-distribution

@anton

This is basically copying over @anton's great script! Also had to run `make format` to make this pass `test_lint`. This PR also makes the make commands for tools further align with the tendermint implementation.

* Add arg to PrintUnsignedStdTx() to actually operate in offline mode * WIP simplifying server module * Expose ExternalIP() * Move {GenTx,Init}Cmd into gaia's new init package

…v/lock_tools

codecov · 2018-10-26T11:56:46Z

Codecov Report

Merging #2603 into master will decrease coverage by 4.93%.
The diff coverage is 36.84%.

@@            Coverage Diff             @@
##           master    #2603      +/-   ##
==========================================
- Coverage   63.76%   58.83%   -4.94%     
==========================================
  Files         113      152      +39     
  Lines        6671     9420    +2749     
==========================================
+ Hits         4254     5542    +1288     
- Misses       2131     3508    +1377     
- Partials      286      370      +84

cwgoes · 2018-10-26T11:59:11Z

Just finished stage 6 of the release process - next up: buddy testing & internal testnet.

cwgoes · 2018-10-26T13:07:47Z

500-block multi-seed simulation passes.

alexanderbez · 2018-10-26T13:11:09Z

I think we may need to linkify again? I saw one (BFT gov) entry in the log w/o a link.

cwgoes · 2018-10-26T13:12:13Z

I think we may need to linkify again? I saw one (BFT gov) entry in the log w/o a link.

The script doesn't change anything (wrong regex?) - fixed the gov entry manually.

edit: Also fixed several other entries manually.

cwgoes · 2018-10-26T13:27:24Z

Found a minor doc inconsistency - #2608.

cwgoes · 2018-10-26T13:55:15Z

I can query with gaiacli query proposals just fine, but when I query a particular proposal - gaiacli query proposal 1 - I get:

ERROR: {"codespace":5,"code":1,"abci_code":327681,"message":"Error{Unknown proposal with id 0}"}

cwgoes · 2018-10-26T14:04:31Z

One oddity: #2610. Probably not critical.

cwgoes · 2018-10-26T14:08:23Z

I got everything to work in the client docs except querying proposals.

alexanderbez · 2018-10-26T14:41:19Z

The docs are correct @cwgoes, you must use --proposal-id.

cwgoes · 2018-10-26T14:56:02Z

The docs are correct @cwgoes, you must use --proposal-id.

Oh oops - you're right, thanks - that error message is not helpful though.

cwgoes · 2018-10-26T14:56:38Z

@mossid and I both went through the client docs & validator setup docs, all seems in order, I updated the files with changes to CLI syntax where necessary.

alexanderbez

testedACK 🎉

cwgoes · 2018-10-28T23:42:12Z

CC @jaekwon or @ebuchman for merge - we concurred in the Friday standup that 0.25 is ready for release (unless plans have changed since then).

When you merge this, if you could merge #2604 right after so we can keep in sync that would be 💘 .

rigelrozanski and others added 30 commits October 9, 2018 13:58

...

c973032

Merge PR #2452: Fix LCD Validator Initialization

e251088

Fix IBC paper link

963bcaf

R4R: Fix simulation proposer (#2460)

6d4975e

* Correctly set proposer in randomized simulation * Return nil if no validators are present

Merge remote-tracking branch 'origin/develop' into rigel/fee-distribu…

fc9bafb

…tion

staking changes test_cover fixes

151a81e

Merge branch 'rigel/fee-distribution' of https://github.com/cosmos/co…

ace19d9

…smos-sdk into rigel/fee-distribution

fix initialization of the test

52316d9

fix distr initialization

22de856

Lock binary dependencies to a specific commits / versions

9e334af

This is basically copying over @anton's great script! Also had to run `make format` to make this pass `test_lint`. This PR also makes the make commands for tools further align with the tendermint implementation.

Update changelog

58bedad

Merge branch 'develop' into joon/paramstore-refactor-base

0397540

rename store subspace, add WithTypeTable

5c92a54

ctx with proposer, working through allocation test

3b5e57b

Alessio/server refactor (#2472)

0f4a03b

* Add arg to PrintUnsignedStdTx() to actually operate in offline mode * WIP simplifying server module * Expose ExternalIP() * Move {GenTx,Init}Cmd into gaia's new init package

Disable unparam

0ef1582

Merge PR #2461: Fix IBC paper link

7d45998

keeper_test

900a5f4

allocation tests

f4f39ae

got basic delegation tests working

8e378e2

TestWithdrawDelegationRewardWithCommission

8cb6d10

Fix circle ci

176ea76

Merge PR #2248: Fix PrefixIterator

b921ed2

Merge branch 'develop' into dev/lock_tools

dbd4f30

fix bugs

8201c92

Merge branch 'dev/lock_tools' of github.com:cosmos/cosmos-sdk into de…

586c191

…v/lock_tools

Merge branch 'develop' into joon/paramstore-refactor-base

42c7a09

fix gaiadebug

674d3d6

fix missed conflict

62feae8

Use tendermint/lint :(

a703e6e

cwgoes requested review from rigelrozanski and zramsay as code owners October 26, 2018 11:45

cwgoes mentioned this pull request Oct 26, 2018

Merge 0.25.0 back to develop #2604

Merged

Manually linkify

331b8ee

Manually fix some links

08fa597

cwgoes mentioned this pull request Oct 26, 2018

Incorrect documentation for multisignature public keys #2608

Closed

Docs fixes in progress while running through the release process

cce48dc

More docs fixes

8288490

cwgoes added 2 commits October 26, 2018 16:09

'--voter' is no longer required

860245e

Rectify validator setup documentation

9c28c69

alexanderbez approved these changes Oct 26, 2018

View reviewed changes

jaekwon merged commit 7c5c14f into master Oct 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 0.25.0 (second try) #2603

Release 0.25.0 (second try) #2603

cwgoes commented Oct 26, 2018 •

edited

Loading

codecov bot commented Oct 26, 2018 •

edited

Loading

cwgoes commented Oct 26, 2018

cwgoes commented Oct 26, 2018

alexanderbez commented Oct 26, 2018

cwgoes commented Oct 26, 2018 •

edited

Loading

cwgoes commented Oct 26, 2018

cwgoes commented Oct 26, 2018

cwgoes commented Oct 26, 2018

cwgoes commented Oct 26, 2018

alexanderbez commented Oct 26, 2018

cwgoes commented Oct 26, 2018

cwgoes commented Oct 26, 2018

alexanderbez left a comment •

edited

Loading

cwgoes commented Oct 28, 2018

Release 0.25.0 (second try) #2603

Release 0.25.0 (second try) #2603

Conversation

cwgoes commented Oct 26, 2018 • edited Loading

codecov bot commented Oct 26, 2018 • edited Loading

Codecov Report

cwgoes commented Oct 26, 2018

cwgoes commented Oct 26, 2018

alexanderbez commented Oct 26, 2018

cwgoes commented Oct 26, 2018 • edited Loading

cwgoes commented Oct 26, 2018

cwgoes commented Oct 26, 2018

cwgoes commented Oct 26, 2018

cwgoes commented Oct 26, 2018

alexanderbez commented Oct 26, 2018

cwgoes commented Oct 26, 2018

cwgoes commented Oct 26, 2018

alexanderbez left a comment • edited Loading

Choose a reason for hiding this comment

cwgoes commented Oct 28, 2018

cwgoes commented Oct 26, 2018 •

edited

Loading

codecov bot commented Oct 26, 2018 •

edited

Loading

cwgoes commented Oct 26, 2018 •

edited

Loading

alexanderbez left a comment •

edited

Loading