Make simulation use a transition matrix for block size #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables simulating periods of high load, and periods of low to no load. (low load because future ops will still terminate in that time frame)
Codecov Report
@@ Coverage Diff @@
## develop #2622 +/- ##
===========================================
+ Coverage 58.82% 58.84% +0.02%
===========================================
Files 152 152
Lines 9424 9424
===========================================
+ Hits 5544 5546 +2
+ Misses 3510 3508 -2
Partials 370 370 |
| func createBlockSimulator(testingMode bool, tb testing.TB, t *testing.T, event func(string), invariants []Invariant, ops []WeightedOperation, operationQueue map[int][]Operation, timeOperationQueue []FutureOperation, totalNumBlocks int, displayLogs func()) func( | ||
| blocksize int, r *rand.Rand, app *baseapp.BaseApp, ctx sdk.Context, accounts []Account, header abci.Header, logWriter func(string)) (opCount int) { | ||
| totalOpWeight := 0 | ||
| func createBlockSimulator(testingMode bool, tb testing.TB, t *testing.T, event func(string), invariants []Invariant, ops []WeightedOperation, operationQueue map[int][]Operation, timeOperationQueue []FutureOperation, totalNumBlocks int, avgBlockSize int, displayLogs func()) func( |
There was a problem hiding this comment.
This function signature is extremely hard to read. I think it's not a big change to clean it up here.
There was a problem hiding this comment.
Refactoring it properly will involve wrapping up parameters into structs, but I can split into multipleines here.
alexanderbez
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables simulating periods of high load, and periods of low to no load.
(low load because future ops will still terminate in that time frame)
Once this is merged, I think we should just delete #1924, and make a new issue tagged postlaunch for those remaining items.
The LCD change is from make format.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: