Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix block offsets in printing simulation block number #2641

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

ValarDragon
Copy link
Contributor

Previously was starting at 0, which was confusing in the logs
/cc @rigelrozanski


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #2641 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2641      +/-   ##
===========================================
+ Coverage    58.82%   58.84%   +0.02%     
===========================================
  Files          152      152              
  Lines         9424     9424              
===========================================
+ Hits          5544     5546       +2     
+ Misses        3510     3508       -2     
  Partials       370      370

@rigelrozanski rigelrozanski merged commit db1f45a into develop Oct 31, 2018
@rigelrozanski rigelrozanski deleted the dev/fix_sim_prints branch October 31, 2018 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants