Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Add small utility to add account to genesis.json after gaiad init #2704

Merged
merged 3 commits into from
Nov 9, 2018
Merged

R4R: Add small utility to add account to genesis.json after gaiad init #2704

merged 3 commits into from
Nov 9, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Nov 6, 2018

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes
Copy link
Contributor

cwgoes commented Nov 6, 2018

Needs an entry in PENDING.md, and looks like this doesn't build at the moment.

alexanderbez
alexanderbez reviewed Nov 6, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alessio -- just some minor feedback in addition to what @cwgoes stated.

cmd/gaia/init/genesis_accts.go Outdated Show resolved Hide resolved
cmd/gaia/init/genesis_accts.go Outdated Show resolved Hide resolved
rigelrozanski
rigelrozanski reviewed Nov 6, 2018
View reviewed changes
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 2 me other than the one comment

@alessio alessio changed the title Add small utility to add account to genesis.json after gaiad init R4R: Add small utility to add account to genesis.json after gaiad init Nov 6, 2018
@alexanderbez
Copy link
Contributor

Mhmmm CI still seems to be failing.

@alessio
Copy link
Contributor Author

alessio commented Nov 6, 2018

Rerunning CI now @alexanderbez

@alessio alessio force-pushed the alessio/utility-to-add-accts-to-genesis branch from 183798b to c3a51a0 Compare November 7, 2018 08:56
@codecov
Copy link

codecov bot commented Nov 7, 2018 •
edited
Loading

Codecov Report

Merging #2704 into develop will decrease coverage by 0.19%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           develop   #2704     +/-   ##
=========================================
- Coverage    56.89%   56.7%   -0.2%     
=========================================
  Files          155     156      +1     
  Lines         9751    9784     +33     
=========================================
  Hits          5548    5548             
- Misses        3825    3858     +33     
  Partials       378     378

melekes
melekes approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍓 🍌 🥛

alexanderbez
alexanderbez approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ☕️

cwgoes
cwgoes approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alessio alessio force-pushed the alessio/utility-to-add-accts-to-genesis branch from c3a51a0 to 8f0e28d Compare November 8, 2018 14:16
@alessio alessio force-pushed the alessio/utility-to-add-accts-to-genesis branch from 8f0e28d to 194691f Compare November 9, 2018 10:54
@jackzampolin jackzampolin merged commit 056e75c into develop Nov 9, 2018
@jackzampolin jackzampolin deleted the alessio/utility-to-add-accts-to-genesis branch November 9, 2018 17:41
@jackzampolin jackzampolin restored the alessio/utility-to-add-accts-to-genesis branch November 9, 2018 17:41
@jackzampolin jackzampolin mentioned this pull request Nov 9, 2018
Closed
@alessio alessio deleted the alessio/utility-to-add-accts-to-genesis branch November 9, 2018 17:56
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
@dasanchez
docs: schedule testnet upgrade to v12 (cosmos#2704)
c54975c 
* v12 upgrade height, cosmovisor 1.5.0

* testnet upgraded to v12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@melekes melekes melekes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alessio @cwgoes @alexanderbez @melekes @rigelrozanski @jackzampolin