R4R: Reorganize CLI command structure. #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2728 +/- ##
========================================
Coverage 56.63% 56.63%
========================================
Files 156 156
Lines 9783 9783
========================================
Hits 5541 5541
Misses 3864 3864
Partials 378 378 |
| var chainID string | ||
| chainID, err = types.DefaultChainID() | ||
| // var chainID string | ||
| chainID, err := types.DefaultChainID() |
| @@ -66,8 +68,7 @@ func runConfigCmd(cmd *cobra.Command, args []string) error { | |||
| Home: gaiaCLIHome, | |||
| ChainID: chainID, | |||
| TrustNode: trustNode, | |||
| Encoding: encoding, | |||
| Output: output, | |||
| Output: "text", | |||
There was a problem hiding this comment.
let's please create and use a newCliConfig(...) function for here (avoid missing structs in the future)
There was a problem hiding this comment.
This whole functionality is currently broken. I'll open an issue for that and fix it in another PR if thats OK.
alessio
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
Agreed with @rigelrozanski's remark on newCliConfig. Other than that, the rest looks good to me. Thanks @jackzampolin
cwgoes
approved these changes
Nov 8, 2018
client/config.go
Outdated
| output := "text" | ||
| var chainID string | ||
| chainID, err = types.DefaultChainID() | ||
| // var chainID string |
alexanderbez
suggested changes
Nov 8, 2018
cmd/gaia/cmd/gaiacli/query.go
Outdated
| // Group staking queries under a subcommand | ||
| stakeQueryCmd := &cobra.Command{ | ||
| Use: "stake", | ||
| Short: "Querying commands for staking module", |
There was a problem hiding this comment.
Suggested change
| Short: "Querying commands for staking module", | |
| Short: "Querying commands for the staking module", |
cmd/gaia/cmd/gaiacli/query.go
Outdated
| // Group gov queries under a subcommand | ||
| govQueryCmd := &cobra.Command{ | ||
| Use: "gov", | ||
| Short: "Querying commands for gov module", |
There was a problem hiding this comment.
Suggested change
| Short: "Querying commands for gov module", | |
| Short: "Querying commands for the governance module", |
cmd/gaia/cmd/gaiacli/query.go
Outdated
| // Group slashing queries under a subcommand | ||
| slashingQueryCmd := &cobra.Command{ | ||
| Use: "slashing", | ||
| Short: "Querying commands for slashing module", |
There was a problem hiding this comment.
Suggested change
| Short: "Querying commands for slashing module", | |
| Short: "Querying commands for the slashing module", |
cmd/gaia/cmd/gaiacli/tx.go
Outdated
|
|
||
| stakeTxCmd := &cobra.Command{ | ||
| Use: "stake", | ||
| Short: "Stake Transactions subcommands", |
There was a problem hiding this comment.
Suggested change
| Short: "Stake Transactions subcommands", | |
| Short: "Staking transaction subcommands", |
cmd/gaia/cmd/gaiacli/tx.go
Outdated
|
|
||
| distTxCmd := &cobra.Command{ | ||
| Use: "dist", | ||
| Short: "Distribution Transactions subcommands", |
There was a problem hiding this comment.
Suggested change
| Short: "Distribution Transactions subcommands", | |
| Short: "Distribution transaction subcommands", |
cmd/gaia/cmd/gaiacli/tx.go
Outdated
|
|
||
| govTxCmd := &cobra.Command{ | ||
| Use: "gov", | ||
| Short: "Governance Transactions subcommands", |
There was a problem hiding this comment.
Suggested change
| Short: "Governance Transactions subcommands", | |
| Short: "Governance transaction subcommands", |
cmd/gaia/cmd/gaiacli/tx.go
Outdated
|
|
||
| slashingTxCmd := &cobra.Command{ | ||
| Use: "slashing", | ||
| Short: "Slashing Transactions subcommands", |
There was a problem hiding this comment.
Suggested change
| Short: "Slashing Transactions subcommands", | |
| Short: "Slashing transaction subcommands", |
fedekunze
reviewed
Nov 8, 2018
|
awesome, much cleaner :) I've opened #2732 to track the docs update from this PR |
Co-Authored-By: jackzampolin <jack.zampolin@gmail.com>
27 tasks
|
Waiting on docs per @jackzampolin |
jackzampolin
added a commit
that referenced
this pull request
Nov 12, 2018
|
Updated new docs to reflect changes here. |
|
Tests keep failing |
|
@jackzampolin do you need help with this one? |
|
@alexanderbez Thanks for the offer, but I think I've got this fixed! |
zramsay
pushed a commit
that referenced
this pull request
Nov 13, 2018
chillyvee
pushed a commit
to chillyvee/cosmos-sdk
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2575
Only one
cmd.AddCommandis called for each so command registration is more declarative. There are a number of docs fixes that will be entailed here, but we are currently refactoring all of that documentation.cc @gamarin2 @zramsay @ValarDragon @alessio