Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Add --chain-id to testnet command #2749

Merged
merged 2 commits into from
Nov 9, 2018
Merged

R4R: Add --chain-id to testnet command #2749

merged 2 commits into from
Nov 9, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Nov 9, 2018 •
edited
Loading

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

cwgoes
cwgoes approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@greg-szabo
Copy link
Member

Awesome, this is exactly what I need.

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #2749 into develop will decrease coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #2749      +/-   ##
===========================================
- Coverage    56.89%   56.85%   -0.05%     
===========================================
  Files          155      155              
  Lines         9751     9755       +4     
===========================================
- Hits          5548     5546       -2     
- Misses        3825     3831       +6     
  Partials       378      378

@cwgoes cwgoes merged commit 2aa14d9 into develop Nov 9, 2018
@cwgoes cwgoes deleted the alessio/local-testnet-chainid-flag branch November 9, 2018 15:44
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
@mpoke
chore: update main to v14 (cosmos#2749)
8beddea 
* replace v13 with v14

* update test.yml

* add v14 upgrade handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@greg-szabo greg-szabo Awaiting requested review from greg-szabo

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @greg-szabo @cwgoes