-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Fix redelegation command follow up to #2727 #2786
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2786 +/- ##
===========================================
- Coverage 56.65% 56.63% -0.03%
===========================================
Files 156 156
Lines 9783 9783
===========================================
- Hits 5543 5541 -2
- Misses 3862 3864 +2
Partials 378 378 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@@ -211,26 +211,11 @@ func GetCmdDelegate(cdc *codec.Codec) *cobra.Command { | |||
return cmd | |||
} | |||
|
|||
// GetCmdRedelegate implements the redelegate validator command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk, I think the original godoc made more sense, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, it did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! 🙊 messed this one up @alexanderbez
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh well. Quick trigger finger on this one.
This PR fixes the same issue as #2727