Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix redelegation command follow up to #2727 #2786

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Conversation

jackzampolin
Copy link
Member

This PR fixes the same issue as #2727

@jackzampolin jackzampolin changed the title Fix redelegation command follow up to #2727 R4R: Fix redelegation command follow up to #2727 Nov 12, 2018
@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #2786 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2786      +/-   ##
===========================================
- Coverage    56.65%   56.63%   -0.03%     
===========================================
  Files          156      156              
  Lines         9783     9783              
===========================================
- Hits          5543     5541       -2     
- Misses        3862     3864       +2     
  Partials       378      378

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 4177f30 into develop Nov 12, 2018
@cwgoes cwgoes deleted the jack/redelegate-fix branch November 12, 2018 21:18
@@ -211,26 +211,11 @@ func GetCmdDelegate(cdc *codec.Codec) *cobra.Command {
return cmd
}

// GetCmdRedelegate implements the redelegate validator command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk, I think the original godoc made more sense, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, it did

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 🙊 messed this one up @alexanderbez

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh well. Quick trigger finger on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants