WIP: Add tx indexing #283
Merged
WIP: Add tx indexing #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
approved these changes
Nov 30, 2017
melekes
reviewed
Nov 30, 2017
modules/coin/handler.go
Outdated
| return sdk.DeliverResult{Tags: tags}, nil | ||
| } | ||
|
|
||
| func tagInt(key string, val int64) *abci.KVPair { |
There was a problem hiding this comment.
Would be great! And rename them :)
melekes
reviewed
Dec 1, 2017
| } | ||
| txl, ok := tx.Unwrap().(sdk.TxLayer) | ||
| for ok { | ||
| tx = txl.Next() |
There was a problem hiding this comment.
don't know the context, but a comment would be nice. are we getting the last tx in the list?
melekes
reviewed
Dec 1, 2017
| } | ||
|
|
||
| // FindAnyTx search all of the strings sequentionally and | ||
| // returns combined result |
There was a problem hiding this comment.
Are you handling duplicates? No, right? Or it's fine
ethanfrey
force-pushed
the
feature/indexing
branch
from
98aa7fc to
38fdd7a
Compare
alexanderbez
pushed a commit
that referenced
this pull request
Jul 18, 2022
brendan-kelly
referenced
this pull request
in figment-networks/cosmos-sdk
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on tendermint/tendermint#835
Trying to expose tx indexes on send tx for the ui to build on
Also see: luniehq/lunie#35