Fix baseapp ante handler simulation mode bug #2847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, app.initializeContext was ignoring the ctx's MultiStore and setting a new one from the app, which was making things pretty confusing.
Also, before, context.multiStore() used to be unexposed, but there's no real need to because MultiStore doesn't expose the keys. So this is now exposed to make the PR here possible and simplify the baseapp logic a bit.
If context.MultiStore() were the CommitMultiStore, there is an least-authority security issue, because the CommitMultiStore exposes more than is safe for ante-handlers and handlers to work with, but with the current BaseApp implementation, this is not an issue as the context.MultiStore() passed in to ante-handler, handler, beginBlocker, and endBlocker are all CacheMultiStores.
Related issue: #2867
Related issue: #2824