Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Don't get command through client.{Get,Post}Commands() #2886

Merged
merged 4 commits into from
Nov 26, 2018
Merged

R4R: Don't get command through client.{Get,Post}Commands() #2886

merged 4 commits into from
Nov 26, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Nov 22, 2018 •
edited
Loading

Logic has changed recently and commands are now enriched with flags by default.

Closes: #2884

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Don't get command through client.{Get,Post}Commands()
c245a3d 
Logic has changed recently and commands are now enriched
with flags by default.

Closes: #2884
@alessio alessio requested a review from zramsay as a code owner November 22, 2018 13:53
@codecov
Copy link

codecov bot commented Nov 22, 2018 •
edited
Loading

Codecov Report

Merging #2886 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2886   +/-   ##
========================================
  Coverage    56.82%   56.82%           
========================================
  Files          120      120           
  Lines         8298     8298           
========================================
  Hits          4715     4715           
  Misses        3265     3265           
  Partials       318      318

@alessio alessio changed the title Don't get command through client.{Get,Post}Commands() R4R: Don't get command through client.{Get,Post}Commands() Nov 22, 2018
fedekunze
fedekunze reviewed Nov 22, 2018
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, will test it afterwards

alexanderbez
alexanderbez approved these changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + tested ☕️

cwgoes
cwgoes approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cwgoes cwgoes merged commit c21961b into develop Nov 26, 2018
@cwgoes cwgoes deleted the alessio/2884-fix-recursive-post-get-commands-calls branch November 26, 2018 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze left review comments

@cwgoes cwgoes cwgoes approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@zramsay zramsay Awaiting requested review from zramsay

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @alexanderbez @cwgoes @fedekunze