R4R: Assign validator initial bonded height #2910
Conversation
HaoyangLiu
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alexanderbez
changed the title
| @@ -104,6 +104,7 @@ func handleMsgCreateValidator(ctx sdk.Context, msg types.MsgCreateValidator, k k | |||
| } | |||
|
|
|||
| validator := NewValidator(msg.ValidatorAddr, msg.PubKey, msg.Description) | |||
| validator.BondHeight = ctx.BlockHeight() | |||
There was a problem hiding this comment.
Is this the best place for the change given that a validator may still not enter the bonded set here? Just thinking about semantics...
There was a problem hiding this comment.
This doesn't make sense - bond height is supposed to be set when the validator is bonded, not when it is created. This code is erroneous if you are creating a validator with "tiny" stake for chain where the validator group is already full
There was a problem hiding this comment.
yeah. I think we can close this PR and another one be opened that addresses the deeper problem.
There was a problem hiding this comment.
Thanks for the bug report. I don't think this addresses the root of the problem.
See #2909 (comment) and let's discuss on the issue first.
|
This PR doesn't address the provided issue sufficiently and is also missing a bunch of requirements from the Contributing Guidelines... Let's come to consensus in the issue before opening PRs in the future. |
Closes: #2909