Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Upgrade tendermint to 0.26.4 #2911

Closed
wants to merge 5 commits into from
Closed

WIP: Upgrade tendermint to 0.26.4 #2911

wants to merge 5 commits into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Nov 27, 2018 •
edited
Loading

  • Reintroduce gaia lite --insecure mode (closes: Reintroduce the ability to run Gaia Lite in "insecure" mode #2715).

  • Update Gopkg.toml accordingly.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio requested a review from jackzampolin November 27, 2018 12:01
@alessio alessio added the wip label Nov 27, 2018
Upgrade tendermint to 0.26.3
0fec28a 
- Reintroduce gaia lite --insecure mode (closes: #2715).
- Update Gopkg.toml accordingly.
@alessio alessio force-pushed the alessio/tendermint-0.26.3 branch from 44f7781 to 0fec28a Compare November 27, 2018 12:07
alexanderbez
alexanderbez reviewed Nov 27, 2018
View reviewed changes
client/lcd/root.go Outdated Show resolved Hide resolved
@joe-bowman
Copy link
Contributor

Any chance we can get 0.26.4 in, as it has fixes useful for some validators in GoS

@alessio alessio changed the title WIP: Upgrade tendermint to 0.26.3 WIP: Upgrade tendermint to 0.26.4 Nov 27, 2018
jackzampolin
jackzampolin approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Glad we are getting this fix in! Let's try to merge this once the tests are passing.

@alessio
Copy link
Contributor Author

alessio commented Nov 28, 2018

We shall open a new PR when tendermint 0.27 is ready

@alessio alessio closed this Nov 28, 2018
@alessio alessio deleted the alessio/tendermint-0.26.3 branch November 28, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez left review comments

@jackzampolin jackzampolin jackzampolin approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reintroduce the ability to run Gaia Lite in "insecure" mode
4 participants
@alessio @joe-bowman @alexanderbez @jackzampolin