-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover key endpoint #292
Recover key endpoint #292
Conversation
Is someone working on this ? I can look tonight |
Working on this now. Does it need to return the seed? It shouldn't since it's already in the request right? I'm also doing some refactoring to clean up this code a bit |
As far as I can tell there are no tests for anything in |
See #293 Includes these commits rebased on develop, plus some refactoring and test :) |
Yeah, rest was in a proof of concept stage. There was no strong feedback ui team was using it, bad issues, etc until October, when development has halted on Sdk. The only tests are integration tests under rest.sh Rest should be overhauled as part of the rewrite. But external functionality remain the same. |
Thanks frey. Seems the All the |
The UI needs a way to recover keys from a mnemonic. I added an endpoint copying the behavior of the CLI.
I added this, but know that there are tests missing. Could someone maybe assist me with those?