Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow supported pubKey types #2949

Merged
merged 4 commits into from
Nov 29, 2018
Merged

Only allow supported pubKey types #2949

merged 4 commits into from
Nov 29, 2018

Conversation

hendrikhofstadt
Copy link
Contributor

@hendrikhofstadt hendrikhofstadt commented Nov 29, 2018

Closes #2945

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

x/stake/types/errors.go Outdated Show resolved Hide resolved
types/context.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #2949 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2949      +/-   ##
===========================================
+ Coverage    56.27%   56.32%   +0.05%     
===========================================
  Files          120      120              
  Lines         8411     8417       +6     
===========================================
+ Hits          4733     4741       +8     
+ Misses        3356     3354       -2     
  Partials       322      322

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants