-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Add Missing genesis checks in Gaia #3010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of changes above, but once those are resolved, looks good!
Codecov Report
@@ Coverage Diff @@
## develop #3010 +/- ##
==========================================
- Coverage 55.53% 55.5% -0.03%
==========================================
Files 120 120
Lines 8490 8494 +4
==========================================
Hits 4715 4715
- Misses 3453 3457 +4
Partials 322 322 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing those! Looks good from my end!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor inconsistencies, otherwise LGTM.
Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>
CI passing besides |
Closes #3009
still some more genesis checks to write missing in the modules, added some empty structs there though and these reference issues:
REF: #3007, #3008
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: