Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Add Missing genesis checks in Gaia #3010

Merged
merged 8 commits into from
Dec 7, 2018
Merged

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Dec 5, 2018

Closes #3009

still some more genesis checks to write missing in the modules, added some empty structs there though and these reference issues:
REF: #3007, #3008

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of changes above, but once those are resolved, looks good!

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #3010 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop   #3010      +/-   ##
==========================================
- Coverage    55.53%   55.5%   -0.03%     
==========================================
  Files          120     120              
  Lines         8490    8494       +4     
==========================================
  Hits          4715    4715              
- Misses        3453    3457       +4     
  Partials       322     322

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing those! Looks good from my end!

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor inconsistencies, otherwise LGTM.

cmd/gaia/app/genesis.go Show resolved Hide resolved
x/distribution/types/genesis.go Outdated Show resolved Hide resolved
PENDING.md Outdated Show resolved Hide resolved
x/distribution/types/genesis.go Outdated Show resolved Hide resolved
cwgoes and others added 2 commits December 6, 2018 18:15
Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>
@rigelrozanski
Copy link
Contributor Author

CI passing besides codecov/patch

@cwgoes cwgoes merged commit 49da96b into develop Dec 7, 2018
@rigelrozanski rigelrozanski deleted the rigel/missing-gen-checks branch January 3, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:genesis relating to chain genesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants