R4R: Reintroduce collect-gentxs's --gentx-dir flag #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #3021 +/- ##
===========================================
- Coverage 52.17% 52.15% -0.03%
===========================================
Files 136 136
Lines 9619 9626 +7
===========================================
+ Hits 5019 5020 +1
- Misses 4263 4269 +6
Partials 337 337 |
alessio
force-pushed
the
alessio/collect-stdxs-reintroduce-gentx-dir-flag
branch
from
151cb96
to
c05d6c2
Compare
alessio
changed the title
alexanderbez
reviewed
Dec 7, 2018
jackzampolin
requested changes
Dec 7, 2018
added 2 commits
December 11, 2018 12:32
It went lost in last genesis workflow refactoring. Also address structs initializations as per #2835.
alessio
force-pushed
the
alessio/collect-stdxs-reintroduce-gentx-dir-flag
branch
from
f8f91d5
to
46bb2d0
Compare
|
Test case added @jackzampolin @alexanderbez |
alessio
commented
Dec 11, 2018
| @@ -29,8 +29,6 @@ const ( | |||
| FlagGenesisFormat = "genesis-format" | |||
| FlagNodeID = "node-id" | |||
| FlagIP = "ip" | |||
|
|
|||
| FlagOutputDocument = "output-document" // inspired by wget -O | |||
There was a problem hiding this comment.
Moved it to client/flags.go as it is unused in stake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was lost in the last genesis workflow refactoring.
Also address structs initializations as per #2835.
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: