Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Catch overflows in gas wanted #3072

Merged
merged 4 commits into from
Dec 10, 2018
Merged

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Dec 10, 2018

Closes #3071


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

baseapp/baseapp.go Show resolved Hide resolved
baseapp/baseapp.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #3072 into develop will increase coverage by 0.02%.
The diff coverage is 60%.

@@             Coverage Diff             @@
##           develop    #3072      +/-   ##
===========================================
+ Coverage    52.15%   52.17%   +0.02%     
===========================================
  Files          136      136              
  Lines         9614     9619       +5     
===========================================
+ Hits          5014     5019       +5     
+ Misses        4264     4263       -1     
- Partials       336      337       +1

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⚡️

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the better error handling here!

@cwgoes cwgoes merged commit 2435761 into develop Dec 10, 2018
@cwgoes cwgoes deleted the cwgoes/fix-intrablock-gas-overflow branch December 10, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants