New App structure #314
Merged
New App structure #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebuchman
reviewed
Dec 30, 2017
| } | ||
| ``` | ||
|
|
||
| While well-written decorators wouldn't mutate any mutable context values, a malicious or buggy plugin can create unwanted side-effects, so it is highly advised for users of Context to only set immutable values. To help enforce this contract, we require values to be certain primitive types, or a Cloner. |
ebuchman
reviewed
Jan 2, 2018
| Data: result.Data, | ||
| Log: result.Log, | ||
| GasWanted: result.GasWanted, | ||
| GasUsed: result.GasUsed, |
| return | ||
| */ | ||
| // Implements ABCI | ||
| func (app *App) EndBlock(req abci.RequestEndBlock) (res abci.ResponseEndBlock) { |
There was a problem hiding this comment.
we need a way for plugins to run code here
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Apr 19, 2021
rootulp
referenced
this pull request
in rootulp/cosmos-sdk
May 17, 2023
* feat: add validator by EVM address query to staking module * chore: gofumpt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.