-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Fixed merkle proof error #3236
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3236 +/- ##
===========================================
- Coverage 54.88% 54.87% -0.01%
===========================================
Files 133 133
Lines 9555 9556 +1
===========================================
Hits 5244 5244
- Misses 3989 3990 +1
Partials 322 322 |
Codecov Report
@@ Coverage Diff @@
## develop #3236 +/- ##
===========================================
+ Coverage 55.35% 55.37% +0.02%
===========================================
Files 134 134
Lines 9594 9594
===========================================
+ Hits 5311 5313 +2
+ Misses 3951 3949 -2
Partials 332 332 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small remark on the changes, but they LGTM 👍
Also, this warrants a pending log entry. Any chance we could test this behavior too?
This looks like a duplicate PR of #3191 |
This PR has the same issue as #3191. In this PR, the lcd test doesn't run in distrust mode, so all tests passed. |
Closing in favor of #3191. |
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: