Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: CLI Test refactor and coverage increase #3250

Merged
merged 19 commits into from
Jan 9, 2019
Merged

R4R: CLI Test refactor and coverage increase #3250

merged 19 commits into from
Jan 9, 2019

Conversation

jackzampolin
Copy link
Member

@jackzampolin jackzampolin commented Jan 8, 2019 •
edited
Loading

  • Fixes CLI Test Refactor #3025
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@0e26a39). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #3250   +/-   ##
==========================================
  Coverage           ?   54.86%           
==========================================
  Files              ?      133           
  Lines              ?     9552           
  Branches           ?        0           
==========================================
  Hits               ?     5241           
  Misses             ?     3989           
  Partials           ?      322

@jackzampolin jackzampolin changed the title WIP: CLI Test refactor and coverage increase R4R: CLI Test refactor and coverage increase Jan 8, 2019
alessio
alessio reviewed Jan 8, 2019
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good 👍

cmd/gaia/cli_test/test_helpers.go Show resolved Hide resolved
alessio
alessio approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go for me

fedekunze
fedekunze approved these changes Jan 9, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome !

@jackzampolin jackzampolin merged commit d1e7693 into develop Jan 9, 2019
@jackzampolin jackzampolin deleted the jack/test-refactor branch January 9, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@alessio alessio alessio approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackzampolin @alessio @fedekunze