R4R: print out sdk.AccAddress.String() instead of hex

[alessio]

I've noticed from a terminal log submitted by @faboweb that the gentx command printed out account's address in hex format instead of bech32:

/Users/fabo/Development/voyager/builds/Gaia/darwin_amd64/g
aiad gentx --name main-account --home /Users/fabo/Development
/voyager/builds/testnets/local-testnet/node_home_1 --home-cli
ent /Users/fabo/Development/voyager/builds/testnets/local-tes
tnet/cli_home_1
ERROR: Account 73F007B29DB6F8E794BB10C915612B6FDC32302E is in genesis, but the only has 0stake available to stake, not 100stake

This small PR addresses that. It also lower caps on output strings - errors messages should not begin with capital letters.

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added entries in PENDING.md with issue #
• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #3286 into develop will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop    #3286   +/-   ##
========================================
  Coverage    55.18%   55.18%           
========================================
  Files          134      134           
  Lines         9526     9526           
========================================
  Hits          5257     5257           
  Misses        3938     3938           
  Partials       331      331

[fedekunze]

utACK

[alessio]

You're most definitely correct. Fixed, thanks

…

On Sat, Jan 12, 2019 at 3:27 PM Federico Kunze ***@***.***> wrote: ***@***.**** approved this pull request. utACK ------------------------------ In PENDING.md <#3286 (comment)>: > @@ -19,6 +19,7 @@ BREAKING CHANGES * #2838 - Move store keys to constants * [\#3162](#3162) The `--gas` flag now takes `auto` instead of `simulate` in order to trigger a simulation of the tx before the actual execution. + * [\#3286](#3286) Fix `gaiad gentx` printout of account's addresses, i.e. user bech32 instead of hex. I don't think this is a breaking change, just an improvement — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3286 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN_7MpYSxUp2nhmFIDv6sZdnGHjR7Tvks5vCf7OgaJpZM4Z8r23> .

-- Alessio Treglia | alessio@tendermint.com 0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A

[faboweb]

Nice.