Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Enable/disable withdraw addresses with a parameter #3292

Merged
merged 52 commits into from
Jan 16, 2019
Merged

R4R: Enable/disable withdraw addresses with a parameter #3292

merged 52 commits into from
Jan 16, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jan 14, 2019 •
edited
Loading

Closes #3252
Blocked on #3099

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes
Refactor old distribution code in prep for F1
22a9d7c
@cwgoes
Update PENDING.md
ad90d2c
@cwgoes
Types; basic layout; BeginBlock allocation
667f83c
@cwgoes
Periods; hooks; handler; simulation
c0babcc
@cwgoes
Merge branch 'develop' into cwgoes/mclaren-mcl33-first-pass
ff6ffe5
@cwgoes
Merge branch 'develop' into cwgoes/mclaren-mcl33-first-pass
db781b8
@cwgoes
A few bug fixes; simulation testing; testcases
20861f8
@cwgoes
Import/export full distribution state
459a7ab
@cwgoes
Actually withdraw validator commission
e9a3f6f
@cwgoes
Merge branch 'develop' into cwgoes/mclaren-mcl33-first-pass
93612a0
@cwgoes
Add TODOs in response to @ValarDragon comments
bfb231e
@cwgoes
Allocation tests
1d3dfc9
@cwgoes
Calculation tests in progress
284c3e5
@cwgoes
Add multi-delegator calculation test
78683de
@cwgoes
Add test for calculation after a slash
2057328
@cwgoes
Iterate over all validators, since we don't force commission-withdraw
da50794
@cwgoes
Fix minor one-off bug; add testcase
c87cc3b
@cwgoes
Include error bound in simulation invariant
0968752
@cwgoes
Remove unused testcase
135a007
@cwgoes
'make format'
660ead7
@cwgoes
Merge branch 'develop' into cwgoes/mclaren-mcl33-first-pass
6d91b02
@cwgoes
Clear historical rewards on export-for-zero-height
55e6d57
@cwgoes
Add comment about implicit key height
800f622
@cwgoes
Fix linter
1bb8714
@cwgoes
Add multi-delegator multi-slash test
93ec057
@cwgoes
Wait 2 blocks on CLI test (?)
c623d47
@cwgoes
Remove CanWithdrawInvariant from runtime (a bit expensive)
0a758f2
@cwgoes
Reset block height for zero-height export
d233f6d
@cwgoes
Merge branch 'develop' into cwgoes/mclaren-mcl33-first-pass
80c3d87
@cwgoes
Merge branch 'develop' into cwgoes/mclaren-mcl33-first-pass
89655bc
@cwgoes cwgoes removed the wip label Jan 14, 2019
@cwgoes cwgoes added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Jan 14, 2019
@jackzampolin
Copy link
Member

jackzampolin commented Jan 14, 2019 •
edited
Loading 

--- FAIL: TestSlashWithRedelegation (0.09s)
panic: division by zero [recovered]
	panic: division by zero

@cwgoes
Copy link
Contributor Author

cwgoes commented Jan 14, 2019 

--- FAIL: TestSlashWithRedelegation (0.09s)
panic: division by zero [recovered]
	panic: division by zero

I merged one commit too early, fixed now.

jackzampolin
jackzampolin approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Also glad we caught this.

@jackzampolin
Copy link
Member

A couple of merge conflicts here then its ready to go @cwgoes

@cwgoes cwgoes changed the base branch from cwgoes/mclaren-mcl33-first-pass to develop January 16, 2019 21:38
@cwgoes cwgoes requested a review from zramsay as a code owner January 16, 2019 21:46
@cwgoes cwgoes force-pushed the cwgoes/disable-withdraw-addresses branch from fa0173c to 51bd7c8 Compare January 16, 2019 21:48
@cwgoes
Copy link
Contributor Author

cwgoes commented Jan 16, 2019

Rebased.

@cwgoes cwgoes removed the S:blocked Status: Blocked label Jan 16, 2019
@cwgoes cwgoes merged commit 0684a42 into develop Jan 16, 2019
@cwgoes cwgoes deleted the cwgoes/disable-withdraw-addresses branch January 16, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@zramsay zramsay Awaiting requested review from zramsay

Assignees
No one assigned
Labels
C:x/distribution distribution module related T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cwgoes @jackzampolin @rigelrozanski @alexanderbez