Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Non-zero-height export fix #3304

Merged
merged 2 commits into from
Jan 16, 2019
Merged

R4R: Non-zero-height export fix #3304

merged 2 commits into from
Jan 16, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jan 15, 2019

We need to load the latest height if we aren't loading a specific height.


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jackzampolin
Copy link
Member

Weird test failures here...

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #3304 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3304      +/-   ##
===========================================
+ Coverage    55.65%   55.65%   +<.01%     
===========================================
  Files          134      134              
  Lines         9716     9713       -3     
===========================================
- Hits          5407     5406       -1     
+ Misses        3965     3963       -2     
  Partials       344      344

@cwgoes
Copy link
Contributor Author

cwgoes commented Jan 16, 2019

Weird test failures here...

Resolved.

@cwgoes cwgoes merged commit eff1f7c into develop Jan 16, 2019
@cwgoes cwgoes deleted the cwgoes/minor-export-fix branch January 16, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants