-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Implement GenesisState.Sanitize() #3397
Conversation
cc0fe5b
to
8f910c7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3397 +/- ##
===========================================
- Coverage 59.38% 59.37% -0.02%
===========================================
Files 131 131
Lines 9862 9868 +6
===========================================
+ Hits 5857 5859 +2
- Misses 3632 3637 +5
+ Partials 373 372 -1 |
e7689ce
to
76fb55e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great additions here. I held comments cause they were all ++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly LGTM, left a few minor remarks though 👍
76fb55e
to
461708b
Compare
Add GenesisState.Sanitize(). It sorts genesis accounts and coin sets to ensure genesis state passes validation. gaia app calls GenesisState.Sanitize() on initFromGenesisState() before processing the genesis state. Closes: #3390
ee6fbf1
to
90cbfb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implement genesis file sanitization to avoid failures at chain init.
coin sets to ensure genesis state passes validation.
before processing the genesis state.
Closes: #3390
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: