-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Add validate-genesis command #3399
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3b028e7
Add validate-genesis command
jackzampolin a9f851e
Add pending
jackzampolin cf61173
Add CLI test and address @alessio and @rigelrozanski PR comment
jackzampolin 2c4b195
Fix test
jackzampolin ae4e0cd
Fix tests
jackzampolin 19ecc91
Print diagnostic to stderr
jackzampolin 0b9016a
Address lint failure
jackzampolin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
package init | ||
|
||
import ( | ||
"fmt" | ||
|
||
"github.com/cosmos/cosmos-sdk/cmd/gaia/app" | ||
"github.com/cosmos/cosmos-sdk/codec" | ||
"github.com/cosmos/cosmos-sdk/server" | ||
"github.com/pkg/errors" | ||
"github.com/spf13/cobra" | ||
"github.com/tendermint/tendermint/types" | ||
) | ||
|
||
// Validate genesis command takes | ||
func ValidateGenesisCmd(ctx *server.Context, cdc *codec.Codec) *cobra.Command { | ||
return &cobra.Command{ | ||
Use: "validate-genesis [file]", | ||
Args: cobra.RangeArgs(0, 1), | ||
Short: "validates the genesis file at the default location or at the location passed as an arg", | ||
RunE: func(cmd *cobra.Command, args []string) (err error) { | ||
var genesis string | ||
var genDoc types.GenesisDoc | ||
var genstate app.GenesisState | ||
|
||
// Load default if passed no args, otherwise load passed file | ||
if len(args) == 0 { | ||
genesis = ctx.Config.GenesisFile() | ||
} else { | ||
genesis = args[0] | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd add a diagnostic info here just to inform the user which location
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great add! Thank you! |
||
if genDoc, err = loadGenesisDoc(cdc, genesis); err != nil { | ||
return errors.Errorf("Error loading genesis doc from %s: %s", genesis, err.Error()) | ||
} | ||
|
||
if err = cdc.UnmarshalJSON(genDoc.AppState, &genstate); err != nil { | ||
return errors.Errorf("Error unmarshaling genesis doc %s: %s", genesis, err.Error()) | ||
} | ||
|
||
if err = app.GaiaValidateGenesisState(genstate); err != nil { | ||
return errors.Errorf("Error validating genesis file %s: %s", genesis, err.Error()) | ||
} | ||
|
||
fmt.Printf("File at %s is a valid genesis file for gaiad\n", genesis) | ||
return nil | ||
}, | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These vars should be defined right before their first usage (aka
genesis
on line 31 etc.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍