Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: GaiaCLI - refactor/fix --account and --index #3461

Merged
merged 23 commits into from
Feb 5, 2019
Merged

R4R: GaiaCLI - refactor/fix --account and --index #3461

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
cf1d684
Improve coverage
jleni Jan 31, 2019
d0548e9
remove bip44 option in gaiacli
jleni Jan 31, 2019
8db1c3d
Adding support for account, index in REST
jleni Jan 31, 2019
bf7bb31
Improving tests
jleni Jan 31, 2019
7551c8f
Adding additional CLI tests
jleni Jan 31, 2019
8eb5abe
updating pending.md
jleni Jan 31, 2019
83b68ae
Fixing linter problems
jleni Jan 31, 2019
e6159c8
applying go fmt + fixing test
jleni Jan 31, 2019
1f9bc37
applying suggestions from code review (step 1)
jleni Feb 1, 2019
44b3e0c
unifying Rest request types
jleni Feb 1, 2019
baffdef
Linter: Adding missing comments
jleni Feb 1, 2019
96ef7b4
Unit test fix + removed warnings
jleni Feb 1, 2019
88e8a57
fixing unit test
jleni Feb 1, 2019
0eb3f04
unifying constants
jleni Feb 1, 2019
095abc3
improving fmt
jleni Feb 2, 2019
dd9a97f
Fixing issue introduced when rebasing
jleni Feb 2, 2019
65dbd0e
small fix
jleni Feb 2, 2019
a52e7c3
Update mnemonic.go
jleni Feb 4, 2019
076185d
Update mnemonic.go
jleni Feb 4, 2019
28c64a7
Merge branch 'develop' into jleni/gaia_args
jleni Feb 4, 2019
287fbba
Fixing merging problems + goimports
jleni Feb 4, 2019
f1f44b7
fixing small issue
jleni Feb 4, 2019
2584e59
Merge remote-tracking branch 'origin/develop' into jleni/gaia_args
jleni Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ BUG FIXES
- [\#3419](https://github.com/cosmos/cosmos-sdk/pull/3419) Fix `q distr slashes` panic
- [\#3453](https://github.com/cosmos/cosmos-sdk/pull/3453) The `rest-server` command didn't respect persistent flags such as `--chain-id` and `--trust-node` if they were
passed on the command line.
- [\#3427](https://github.com/cosmos/cosmos-sdk/issues/3427) Gaiacli generates/recovers the same address irrespective of the --account or --index arguments.

* Gaia

Expand Down
6 changes: 0 additions & 6 deletions client/input.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,6 @@ func GetPassword(prompt string, buf *bufio.Reader) (pass string, err error) {
return pass, nil
}

// GetSeed will request a seed phrase from stdin and trims off
// leading/trailing spaces
func GetSeed(prompt string, buf *bufio.Reader) (string, error) {
return GetString(prompt, buf)
}

// GetCheckPassword will prompt for a password twice to verify they
// match (for creating a new password).
// It enforces the password length. Only parses password once if
Expand Down
Loading