Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: get rid of double negatives: IsNotNegative -> IsAnyNegative #3522

Merged
merged 3 commits into from
Feb 6, 2019
Merged

R4R: get rid of double negatives: IsNotNegative -> IsAnyNegative #3522

merged 3 commits into from
Feb 6, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 6, 2019

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio changed the title WIP: get rid of double negatives: IsNotNegative -> IsAllGTEZero R4R: get rid of double negatives: IsNotNegative -> IsAllGTEZero Feb 6, 2019
jackzampolin
jackzampolin approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackzampolin
Copy link
Member

Test failures are likely the result of circle issues. Lets hold off on merges until the cloud storm settles down.

@alessio alessio changed the title R4R: get rid of double negatives: IsNotNegative -> IsAllGTEZero R4R: get rid of double negatives: IsNotNegative -> IsAnyNegative Feb 6, 2019
@jackzampolin jackzampolin merged commit b63b625 into develop Feb 6, 2019
@jackzampolin jackzampolin deleted the alessio/double-negatives branch February 6, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @jackzampolin @alexanderbez