Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: General Sanitization & Gas Cost Review #3552

Merged
merged 3 commits into from
Feb 8, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 8, 2019

(partially?) addresses #1008


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added this to the v0.31.0 (Launch RC) milestone Feb 8, 2019
@alexanderbez alexanderbez changed the title WIP: General Sanitization & Gas Cost Review R4R: General Sanitization & Gas Cost Review Feb 8, 2019
@alexanderbez
Copy link
Contributor Author

@cwgoes @jackzampolin lmk if there are any other modifications to make or we deem necessary.

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has tests, feels good man 😎 👍

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #3552 into develop will increase coverage by 0.08%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop    #3552      +/-   ##
===========================================
+ Coverage    57.24%   57.33%   +0.08%     
===========================================
  Files          179      179              
  Lines        14105    14133      +28     
===========================================
+ Hits          8075     8103      +28     
+ Misses        5545     5544       -1     
- Partials       485      486       +1

@cwgoes cwgoes merged commit fd5e7b9 into develop Feb 8, 2019
@cwgoes cwgoes deleted the bez/1008-random-sanitization branch February 8, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants