-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: improve denom validation #3666
Conversation
Concept ACK, we should do this sooner rather than later since it reduces the space of acceptable denoms. |
7b12bcb
to
b498705
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3666 +/- ##
===========================================
- Coverage 61.39% 61.39% -0.01%
===========================================
Files 189 189
Lines 14098 14100 +2
===========================================
Hits 8656 8656
- Misses 4886 4888 +2
Partials 556 556 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. Also agree with @cwgoes
Was the limit to 3 characters something that existed before this PR? Was there more reason than limiting the space of acceptable denoms? I'm trying to build an app with single char denoms rn and wondering if there's a good reason not to (besides forking the SDK 🍴) cc @ebuchman |
Goes back even further: 2c1d533#diff-641f1d674d28f26344e36b61db7f47beL12 Probably it's to avoid people squatting smaller denoms and issues with readability/differentiation with less than 3 letters |
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: